Skip to content

Compiler/0.12 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 2, 2018
Merged

Compiler/0.12 #20

merged 9 commits into from
Jun 2, 2018

Conversation

kritzcreek
Copy link
Contributor

@kritzcreek kritzcreek commented May 30, 2018

Cherry picked and merged open PRs.

Closes #11
Closes #12
Closes #14
Closes #15
Closes #16
Closes #17
Closes #18

justinwoo and others added 7 commits May 14, 2018 12:47
The underlying implementation in `node/lib/internal/child_process.js` does
return a boolean value, but this value is devoid of any semantic content.

Shortened it does:

```
if childProcessHandle {
  res = child.kill(signal)
  if (res === 0) {
    child.killed = true;
    return true;
  else {
    throwError()
  }
}
else {
  return false;
}
```

which means the returned boolean depends on whether the subprocess still exists
and whether the signal was successfully sent (apparently the original author
thought that sending a signal will always kill the process).

The return value isn’t even mentioned in the documentation, so it must be a
historical artifact kept around for backward compatibility.
According to the node documentation:
“`'close'` is distinct from the 'exit' event, since multiple processes might
share the same stdio streams.”

https://nodejs.org/api/child_process.html#child_process_event_close
@justinwoo
Copy link
Contributor

Is there something more needed here?

Profpatsch and others added 2 commits June 1, 2018 18:30
Every exposed symbol should be documented now.
@kritzcreek kritzcreek merged commit 97fd9c0 into master Jun 2, 2018
@kritzcreek kritzcreek deleted the compiler/0.12 branch June 2, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants