Skip to content

Update timeout to Milliseconds #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Update timeout to Milliseconds #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Breaking changes:
- Restrict end-user's ability to configure `stdio` to only those appended to `safeStdio` (#46 by @JordanMartinez)

See the module docs for `Node.ChildProcess`.
- All `ChildProcess`-creating functions have been updated to support no args and all args variants (#46 by @JordanMartinez)
- All `ChildProcess`-creating functions have been updated to support no args and all args variants (#46, #48 by @JordanMartinez)

New features:
- Added event handler for `spawn` event (#43 by @JordanMartinez)
Expand Down
6 changes: 3 additions & 3 deletions src/Node/ChildProcess.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ type SpawnOptions =
, shell :: Maybe Shell
, windowsVerbatimArguments :: Maybe Boolean
, windowsHide :: Maybe Boolean
, timeout :: Maybe Number
, timeout :: Maybe Milliseconds
, killSignal :: Maybe KillSignal
}

Expand Down Expand Up @@ -477,7 +477,7 @@ type ExecResult =
type ExecOptions =
{ cwd :: Maybe String
, env :: Maybe (Object String)
, timeout :: Maybe Number
, timeout :: Maybe Milliseconds
, maxBuffer :: Maybe Number
, killSignal :: Maybe KillSignal
, uid :: Maybe Uid
Expand Down Expand Up @@ -616,7 +616,7 @@ execFile cmd args = coerce $ UnsafeCP.execFileOpts cmd args { encoding: "buffer"
type ExecFileOptions =
{ cwd :: Maybe String
, env :: Maybe (Object String)
, timeout :: Maybe Number
, timeout :: Maybe Milliseconds
, maxBuffer :: Maybe Number
, killSignal :: Maybe KillSignal
, uid :: Maybe Uid
Expand Down
6 changes: 3 additions & 3 deletions src/Node/UnsafeChildProcess/Unsafe.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ type JsExecOptions =
( cwd :: String
, env :: Object String
, encoding :: String
, timeout :: Number
, timeout :: Milliseconds
, maxBuffer :: Number
, killSignal :: KillSignal
, uid :: Uid
Expand Down Expand Up @@ -245,7 +245,7 @@ type JsExecFileOptions =
( cwd :: String
, env :: Object String
, encoding :: String
, timeout :: Number
, timeout :: Milliseconds
, maxBuffer :: Number
, killSignal :: KillSignal
, uid :: Uid
Expand Down Expand Up @@ -372,7 +372,7 @@ type JsSpawnOptions =
, shell :: Shell
, windowsVerbatimArguments :: Boolean
, windowsHide :: Boolean
, timeout :: Number
, timeout :: Milliseconds
, killSignal :: KillSignal
)

Expand Down