Skip to content

Cleanup usage of unsafeCoerce #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Cleanup usage of unsafeCoerce #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bff8ed
Cleanup usage of unsafeCoerce
JordanMartinez Jul 25, 2023
a7bab11
Fix PR numbers
JordanMartinez Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,11 @@ Breaking changes:

New features:
- Added `fromKillSignal` (#51 by @JordanMartinez)
- Added `pidExists` (#52 by @JordanMartinez)
- Added `pidExists` (#53 by @JordanMartinez)

Other improvements:
- Fix regression: add `ref`/`unref` APIs that were dropped in `v10.0.0` (#50 by @JordanMartinez)
- Wrap `Unsafe` API via `ChildProcess` in safer way (#54 by @JordanMartinez)

## [v10.0.0](https://github.com/purescript-node/purescript-node-child-process/releases/tag/v10.0.0) - 2023-07-20

Expand Down
26 changes: 13 additions & 13 deletions src/Node/ChildProcess.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,28 +157,28 @@ stderr = toUnsafeChildProcess >>> UnsafeCP.unsafeStderr >>> unsafeFromNull
-- | the process has spawned. Note that if the process has already
-- | exited, another process may have taken the same ID, so be careful!
pid :: ChildProcess -> Effect (Maybe Pid)
pid = unsafeCoerce SafeCP.pid
pid cp = SafeCP.pid $ toUnsafeChildProcess cp

pidExists :: ChildProcess -> Effect Boolean
pidExists = unsafeCoerce SafeCP.pidExists
pidExists cp = SafeCP.pidExists $ toUnsafeChildProcess cp

-- | Indicates whether it is still possible to send and receive
-- | messages from the child process.
connected :: ChildProcess -> Effect Boolean
connected = unsafeCoerce SafeCP.connected

exitCode :: ChildProcess -> Effect (Maybe Int)
exitCode = unsafeCoerce SafeCP.exitCode
exitCode cp = SafeCP.exitCode $ toUnsafeChildProcess cp

-- | Closes the IPC channel between parent and child.
disconnect :: ChildProcess -> Effect Unit
disconnect = unsafeCoerce SafeCP.disconnect
disconnect cp = SafeCP.disconnect $ toUnsafeChildProcess cp

kill :: ChildProcess -> Effect Boolean
kill = unsafeCoerce SafeCP.kill
kill cp = SafeCP.kill $ toUnsafeChildProcess cp

kill' :: KillSignal -> ChildProcess -> Effect Boolean
kill' = unsafeCoerce SafeCP.kill'
kill' sig cp = SafeCP.kill' sig $ toUnsafeChildProcess cp

-- | Send a signal to a child process. In the same way as the
-- | [unix kill(2) system call](https://linux.die.net/man/2/kill),
Expand All @@ -189,25 +189,25 @@ kill' = unsafeCoerce SafeCP.kill'
-- | The child process might emit an `"error"` event if the signal
-- | could not be delivered.
killSignal :: Signal -> ChildProcess -> Effect Boolean
killSignal = unsafeCoerce SafeCP.killSignal
killSignal sig cp = SafeCP.killSignal sig $ toUnsafeChildProcess cp

killed :: ChildProcess -> Effect Boolean
killed = unsafeCoerce SafeCP.killed
killed cp = SafeCP.killed $ toUnsafeChildProcess cp

ref :: ChildProcess -> Effect Unit
ref = unsafeCoerce SafeCP.ref
ref cp = SafeCP.ref $ toUnsafeChildProcess cp

unref :: ChildProcess -> Effect Unit
unref = unsafeCoerce SafeCP.unref
unref cp = SafeCP.unref $ toUnsafeChildProcess cp

signalCode :: ChildProcess -> Effect (Maybe String)
signalCode = unsafeCoerce SafeCP.signalCode
signalCode cp = SafeCP.signalCode $ toUnsafeChildProcess cp

spawnArgs :: ChildProcess -> Array String
spawnArgs = unsafeCoerce SafeCP.spawnArgs
spawnArgs cp = SafeCP.spawnArgs $ toUnsafeChildProcess cp

spawnFile :: ChildProcess -> String
spawnFile = unsafeCoerce SafeCP.spawnFile
spawnFile cp = SafeCP.spawnFile $ toUnsafeChildProcess cp

-- | Note: `exitStatus` combines the `status` and `signal` fields
-- | from the value normally returned by `spawnSync` into one value
Expand Down