Enum.range - all elements of an enum, ordered #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will revisit this shortly, as I think that with some changes it can be used to make more efficient default methods. |
|
To do this properly, I'll want |
|
Another note: not sure that |
Allows for faster default BoundedEnum implementations.
|
Throwing a |
|
|
I like the sound of this. Maybe I name the type |
|
Will resurrect this PR soon as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once NonEmptyArrays and their generators are merged, this will allow us to randomly generate a BoundedEnum element in O(1), safely.
This is partly a successor to #33
I think that technically, this could be relaxed to work with
Enums rather than justBoundedEnums, but that somehow feels like it's in violation of the intent of these two classes.