Changelog updates since v4.1.1 #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesfrain
commented
Jan 18, 2021
| @@ -5,12 +5,22 @@ Notable changes to this project are documented in this file. The format is based | |||
| ## [Unreleased] | |||
|
|
|||
| Breaking changes: | |||
| - Updated code for PureScript 0.14 (#120) | |||
| - Removed `fold1Default` and deprecated `foldMap1Default` (#128) | |||
There was a problem hiding this comment.
I believe this was the net result of breaking changes. Would be good to double-check.
milesfrain
commented
Jan 18, 2021
CHANGELOG.md
Outdated
|
|
||
| New features: | ||
| - Added `findMapWithIndex` (#119) | ||
| - Added `foldr1` `foldl1` `foldr1Default` `foldl1Default` `foldMap1DefaultR` `foldMap1DefaultL` (#121, #128) |
There was a problem hiding this comment.
Ignoring the introduction, then removal of fold1DefaultR fold1DefaultL
CHANGELOG.md
Outdated
|
|
||
| New features: | ||
| - Added `findMapWithIndex` (#119) | ||
| - Added `foldr1` `foldl1` `foldr1Default` `foldl1Default` `foldMap1DefaultR` `foldMap1DefaultL` (#121, #128) |
There was a problem hiding this comment.
Should these be comma-separated, ie.
- Added `foldr1`, `foldl1`, ..., and `foldMap1DefaultL`
hdgarrood
reviewed
Jan 19, 2021
CHANGELOG.md
Outdated
| @@ -5,12 +5,22 @@ Notable changes to this project are documented in this file. The format is based | |||
| ## [Unreleased] | |||
|
|
|||
| Breaking changes: | |||
| - Updated code for PureScript 0.14 (#120) | |||
There was a problem hiding this comment.
I think it's clearer to phrase this as "Added support for PureScript 0.14, and dropped support for all previous versions"
thomashoneyman
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR updates the CHANGELOG in preparation for the upcoming release of this library.
Related: purescript/purescript#3985