Improve foldr performance ~4x on large lists #180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance is improved by using an inlined reverse function, rather than leveraging
foldl
.Both versions appear to be identical, so it's a bit of a bummer that the concise version is so much slower.
There's a moderate speedup for all list sizes, but it's most significant on large lists. Here are the benchmarking results:
Before:
After:
Also refactored the benchmarking code.