sorting for NonEmptyList #97
Conversation
|
@garyb I think we can make this a minor version bump, yes? |
| sort xs = sortBy compare xs | ||
|
|
||
| sortBy :: forall a. (a -> a -> Ordering) -> NonEmptyList a -> NonEmptyList a | ||
| sortBy cmp xs = unsafeFromList $ L.sortBy cmp (toList xs) |
There was a problem hiding this comment.
Another option here is to sort the tail and insert the head into the sorted result, a la insertion sort. That would require us to change the type of insert though, or to provide an alternative version.
There was a problem hiding this comment.
@paf31 are you suggesting we should go down that route? I understand that unsafeFromList is, in many cases, a last resort, but here it seems to be both safe and more efficient than the alternative.
There was a problem hiding this comment.
I'd vote for the unsafeFromList version here too, personally. :)
|
@matthewleon Sorry for the delay, could you please rebase? |
Agreed 👍 |
matthewleon
force-pushed
the
nonempty-funcs
branch
from
60b50b4 to
9729249
Compare
done |
|
Thanks! |
Adds the two sorting functions to
NonEmptyList.