Fix kind warnings #211
Closed
Fix kind warnings #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are fixed in the 0.14 branch aren’t they? |
|
@hdgarrood No, not yet. My previous PR came before the changes Nate made when core contributors decided to emit the "could not generalize kind" warnings. |
hdgarrood
reviewed
Mar 29, 2020
| @@ -14,6 +14,7 @@ module Data.NaturalTransformation where | |||
| -- | `f` and `g` should be functors, but the `Functor` constraint is not | |||
| -- | enforced here; that the types are of kind `Type -> Type` is enough for our | |||
| -- | purposes. | |||
| type NaturalTransformation :: forall k. (k -> Type) -> (k -> Type) -> Type | |||
There was a problem hiding this comment.
This kind signature disagrees with the doc-comments. I feel like perhaps we should make this (Type -> Type) -> (Type -> Type) -> Type unless there is a specific example where the generalized version would be useful.
There was a problem hiding this comment.
(Or alternatively update the doc comments)
There was a problem hiding this comment.
That's a good point, I've updated the doc comments.
|
I don’t remember closing this; I guess must have closed it by accident, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.