Skip to content

Why does splitAt return an array instead of a Tuple? #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MichaelXavier opened this issue Oct 22, 2016 · 0 comments
Closed

Why does splitAt return an array instead of a Tuple? #69

MichaelXavier opened this issue Oct 22, 2016 · 0 comments

Comments

@MichaelXavier
Copy link

splitAt :: Int -> String -> Maybe (Array String). Looking at the FFI, it returns just([s.substring(0, i), s.substring(i)]) : nothing;, always either a Just with a 2-length array or a Nothing. Wouldn't a Tuple be more appropriate?
hdgarrood added a commit that referenced this issue Dec 1, 2016
@hdgarrood
Use a Tuple in splitAt
45afaf6 
Fixes #69
@hdgarrood hdgarrood mentioned this issue Dec 1, 2016
Closed
hdgarrood added a commit that referenced this issue Dec 1, 2016
@hdgarrood
Make splitAt return a record, fixes #69
1e7f574
@garyb garyb closed this as completed in f7f449c Mar 26, 2017
garyb added a commit that referenced this issue Mar 26, 2017
@garyb
Merge pull request #72 from purescript/splitAt-record
8fd322a 
[BREAKING] Make splitAt return a record, fixes #69
@MonoidMusician MonoidMusician mentioned this issue May 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelXavier