Fix missing foreign count function.
#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated the documentation to more accurately reflect the function's behavior. I think the function could be given a better name to communicate its behavior too. Since it's an exported function, I didn't rename it as part of this fix.
|
Hm, yeah this is a slightly strange one. It's a specialised case of |
|
Yeah, it's confusing enough that I actually thought |
|
Thanks for fixing it anyway! |
garyb
added a commit
that referenced
this pull request
Jul 6, 2015
Fix missing foreign `count` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated the documentation to more accurately reflect the function's
behavior.
I think the function could be given a better name to communicate its
behavior too. Since it's an exported function, I didn't rename it as
part of this fix.