created examples for String functions and refactored existing ones
#90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
reviewed
Dec 16, 2017
src/Data/String.purs
Outdated
| -- | | ||
| -- | ```purescript | ||
| -- | lastIndexOf' (Pattern "c") 2 "abcdc" == Just 2 | ||
| -- | lastIndexOf' (Pattern "c") 3 "abcdc" == Just 2 |
There was a problem hiding this comment.
Perhaps it would be better to choose indices which change the result, so that it's a little clearer what's going on? E.g.
lastIndexOf' (Pattern "a") 1 "ababa" == Just 0
lastIndexOf' (Pattern "a") 2 "ababa" == Just 2
lastIndexOf' (Pattern "a") 4 "ababa" == Just 4At the same time, could you please update the comment so that it says "starting at the specified index and searching backwards towards the beginning of the string"?
There was a problem hiding this comment.
This behaviour confused me at first; see #91 for some context.
|
We'll also want to update |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.