Skip to content

pvlib.irradiance.erbs and .disc to accept kt as optional input parameter #1128

Open
@StefaE

Description

@StefaE

Some weather forecasts (eg. Deutscher Wetterdienst, MOSMIX) provide GHI (in MOSMIX 'conveniently' dubbed 'Rad1h' and in units of kJ :-( ) and kt (dubbed 'RRad1)).

Proposal
pvlib.irradiance.erbs could easily be enhanced to optionally accept kt as a parameter:

def erbs(ghi, zenith, datetime_or_doy, min_cos_zenith=0.065, max_zenith=87, kt = None):

   if kt is None:
        kt = clearness_index(ghi, zenith, dni_extra, min_cos_zenith=min_cos_zenith,
                             max_clearness_index=1)

This change should be transparent to current users but allow the use of two input parameters from the forecast, in the hope that they combined describe actual weather conditions more accurately than just one.

A symmetrical change could be proposed for disc, which also first calculates kt. However, due to the usage of I0 for calculating both kt and later dni, this would end up in a considerably less clean situation and should not be lightly done.

Thx. for consideration

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions