Skip to content

improve test_atmosphere #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wholmgren opened this issue May 6, 2016 · 0 comments
Closed

improve test_atmosphere #158

wholmgren opened this issue May 6, 2016 · 0 comments
Labels
easy good first issue help wanted testing
Milestone
0.6.0

Comments

@wholmgren
Copy link
Member

The test_atmosphere module can easily be improved in a few ways:

  1. Add numerical tests.
  2. Replace the Location.get_solarposition calculated zenith angles with prescribed zenith angles. Unneeded complexity and makes it easier to do 1.
  3. Remove unused imports (logging now and location, solarposition once 2. is fixed.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy good first issue help wanted testing
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
1 participant
@wholmgren