Skip to content

fix bug in get_relative_airmass(model=youngirvine1967). improve test_atmosphere #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 27, 2018

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Aug 25, 2018

  • Closes improve test_atmosphere #158 bug in get_relative_airmass(model='youngirvine1967') #545
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

@wholmgren wholmgren added this to the 0.6.0 milestone Aug 25, 2018
@wholmgren wholmgren merged commit e3faaad into pvlib:master Aug 27, 2018
@wholmgren wholmgren deleted the testam branch August 27, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants