-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove Python 2 vestiges #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@markcampanelli your list above is good, but the first point seems to be a separate issue, since it's not clear to me that the current behavior returns the correct number at all, in py2 or py3. At least that's the way the comment on line 214 makes it sound. |
I think that first item was simply what I discovered from just searching the code for Python 2 references. I think it's fine to address that in a separate issue/PR. I don't see a problem with also removing the versioneer future presently if it is not needed. I think you should also search the code for "python 2" and variants. For example, this identifies import checks that are no longer needed, such as pvlib-python/pvlib/iotools/epw.py Line 9 in b61e149
|
Thanks, I've sorted out all the py2-compatible imports. Also, after reading the commit where the comment about python 2 was added in atmosphere.py, I see that we don't need to make a new issue for that. We can just remove the comment because the solution previously found seems to work fine in py2 and py3, and looks a little better than the approach that was only py3 compatible, so no problems there after all. |
With the merging of #728, we can now consider dropping Python2-specific code and workarounds.
Some candidates are:
from __future__ import ...
The text was updated successfully, but these errors were encountered: