Appease a few test warnings #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @kanderso-nrel does it deserve a "what's new" note? |
|
I always ask myself "can I imagine a user reading an entry on this and being glad it was included in the "what's new" file?" and in this case I lean towards "no" and it would just be uninteresting clutter. Of course if anyone else thinks a note is warranted I will happily add one. |
|
@kanderso-nrel & @AdamRJensen did you see, looks like some CI tests are failing lately? GH actions:
commit history:
I'm not sure what's going on? Something to worry about? |
|
Yep, see #1591 (comment) |
|
It's only psm3 in the pytest-remote-data action action: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote-data) and Milestone are assigned to the Pull Request and linked Issue.This PR gets rid of a few warnings emitted by our CI test jobs:
PytestReturnNotNoneWarning: Expected None, but pvlib/tests/test_atmosphere.py::test_kasten96_lt returned array([[[...]]]), which will be an error in a future version of pytest. Did you mean to use `assert` instead of `return`?`test_solarposition.py:166: FutureWarning: iteritems is deprecated and will be removed in a future version. Use .items instead.Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: codecov/codecov-action@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.