Skip to content

Update PSM3 test data to 3.2.2 #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Conversation

kandersolar
Copy link
Member

  • Related to, but does not fully close, iotools.get_psm3 may need some updates for the new 2021 data #1591
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The data returned from the 5-minute PSM3 endpoint has been updated to version 3.2.2, meaning it returns different values from before. This updates the CSV data subset we use for testing to match the new dataset.

@kandersolar kandersolar added testing io remote-data triggers --remote-data pytests labels Jan 27, 2023
@kandersolar kandersolar added this to the 0.9.5 milestone Jan 27, 2023
@kandersolar
Copy link
Member Author

The PSM3 tests are all passing now. The remaining test failure is unrelated and reported in #1609.

Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kanderso-nrel for fixing this :)

@AdamRJensen AdamRJensen merged commit afa47c4 into pvlib:main Feb 1, 2023
@kandersolar kandersolar deleted the psm3-test-fix branch February 1, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io remote-data triggers --remote-data pytests testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants