Skip to content

Fix typo in documentation pvlib.location.Location.get_sun_rise_set_transit #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

echedey-ls
Copy link
Contributor

@echedey-ls echedey-ls commented Jun 17, 2023

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • [ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Fix typo in pvlib.location.Location.get_sun_rise_set_transit
Fixed docs.

@echedey-ls echedey-ls changed the title Fix typo in documentation pvlib.location.Location.get_get_sun_rise_set_transit Fix typo in documentation pvlib.location.Location.get_sun_rise_set_transit Jun 17, 2023
@echedey-ls echedey-ls marked this pull request as ready for review June 17, 2023 11:53
@kandersolar kandersolar added this to the 0.10.0 milestone Jun 17, 2023
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @echedey-ls!

@kandersolar kandersolar merged commit 81598e4 into pvlib:main Jun 18, 2023
@echedey-ls echedey-ls deleted the typo-fix branch April 5, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants