-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add atand function #1927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add atand function #1927
Conversation
Co-authored-by: Kevin Anderson <[email protected]>
Thanks for these improvements @adriesse Co-authored-by: Anton Driesse <[email protected]>
I will say that I wish we would have named inverse sine |
Would |
Certainly not a bad idea - I think I'll hold off adding it until I need it though :P |
I presume the choice of name was motivated by convenience when translating to python from MATLAB (which also uses asind). |
For future reference, search of Valid point anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since normally I probably wouldn't be in favor of adding functions to pvlib.tools
without it being used somewhere in pvlib, I'll point out that we expect to use atand
in an upcoming PR.
Thanks @AdamRJensen
docs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.pvlib has convenience functions for calculating sine, cosine, and tangent in degrees. Similarly, it has functions for arcsine and arccosine but NOT arctangent, which seems inconsistent.
I couldn't find anywhere these functions are tested, but maybe they just aren't?