-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Floating PV gallery example #2110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating PV gallery example #2110
Conversation
Hi @lmicheli! Feel free to give any feedback on this! |
For any reviewers, here's a link to what the gallery page will look like: https://pvlib-python--2110.org.readthedocs.build/en/2110/gallery/floating-pv/plot_floating_pv_cell_temperature.html @IoannisSifnaios having seen the lovely table in the example, I am left wondering what the simulated temperature will look like using all those other parameter sets. What do you think about having the example code iterate through all the sets of coefficients and plotting all of the results instead of just two? |
Co-authored-by: Cliff Hansen <[email protected]>
Co-authored-by: Cliff Hansen <[email protected]>
Co-authored-by: Cliff Hansen <[email protected]>
Hi all, not sure if this is the right way to proceed.... Here some thoughts on the gallery page (great job):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking table rendering, description and fixing some typos.
It would be nice to add an entry under the Documentation
subsection in the appropriate whatsnew, and give credits to @lmicheli for reviewing. Nice job with the example.
Co-authored-by: Echedey Luis <[email protected]>
Co-authored-by: Echedey Luis <[email protected]>
Co-authored-by: Echedey Luis <[email protected]>
Co-authored-by: RDaxini <[email protected]>
Co-authored-by: RDaxini <[email protected]>
Co-authored-by: RDaxini <[email protected]>
Co-authored-by: RDaxini <[email protected]>
Co-authored-by: RDaxini <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @IoannisSifnaios and reviewers!
docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.Addition of gallery example for the use of the PVSyst cell temperature model for floating PV. Essentially, it implements different heat loss coefficients compared to the default values of the PVSyst model.
Information was taken from these papers: 1, 2, 3
The created gallery example can be accessed here.