-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add example of remote fetch of database with pvsystem.retrieve_sam
#2313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@echedey-ls something is wrong with the rendering, check here: https://pvlib-python--2313.org.readthedocs.build/en/2313/reference/generated/pvlib.pvsystem.retrieve_sam.html The problem might be the blank line, but I am not sure. |
Co-authored-by: Kevin Anderson <[email protected]>
rationale: misleading var name
Rationale: be more explicit
@kandersolar you were right. I've done some pretty formatting to the docstring too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice improvements @echedey-ls!
[ ] Closes #xxxx[ ] Tests added[ ] Updates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data
) and Milestone are assigned to the Pull Request and linked Issue.I just always thought this would be useful after working on #2018