Skip to content

Conversation

ramaroesilva
Copy link
Contributor

@ramaroesilva ramaroesilva commented Jul 31, 2025

I think the issue is clear enough.

@ramaroesilva
Copy link
Contributor Author

In #2506 @cwhanse mentions that it is difficult to find the 1981 paper from Ross, to which @kandersolar provided a wayback machine url. Should I add it to the documentation of temperature.ross? If so, how?

Copy link
Member

@RDaxini RDaxini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @ramaroesilva
I added a few suggestions for formatting the docstring and references. Have a look, and if you look under the "files changed" tab you can "add suggestion to batch" and implement more than one suggestion in a single commit

@cwhanse
Copy link
Member

cwhanse commented Aug 1, 2025

@ramaroesilva if you can fix the merge conflicts in the whatsnew file, we can launch the CI. To fix the conflicts, just keep both sets of lines - this sometimes happens when two PRs are adding lines at the same position.

@ramaroesilva
Copy link
Contributor Author

@ramaroesilva if you can fix the merge conflicts in the whatsnew file, we can launch the CI. To fix the conflicts, just keep both sets of lines - this sometimes happens when two PRs are adding lines at the same position.

@cwhanse merge conflict fixed :-)

@cwhanse
Copy link
Member

cwhanse commented Aug 1, 2025

You can ignore the test failure for py3.9

@kandersolar kandersolar mentioned this pull request Sep 19, 2025
9 tasks
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ramaroesilva!

@kandersolar kandersolar merged commit 73b828d into pvlib:main Sep 22, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pvlib.temperature.ross could accept ross parameter as a NOCT alternative
4 participants