Skip to content

Implement IEC 61853 IAM calculations for diffuse irradiance #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Implement IEC 61853 IAM calculations for diffuse irradiance #792

wants to merge 1 commit into from

Conversation

adriesse
Copy link
Member

@adriesse adriesse commented Oct 18, 2019

  • Adresses issue Implement IEC61853 IAM calculations #751
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

@cwhanse
Copy link
Member

cwhanse commented Oct 18, 2019

Thanks @adriesse this is a nice addition. It will go into the iam.py module when #783 is merged. @wholmgren I think I have addressed the review comments for #783, test_get_psm3 still fails due to NSRDB-side data.

@adriesse
Copy link
Member Author

Ok, I hadn't really been paying attention to what you were doing.

Would it be possible to split these kinds of re-orgs into steps? Like perhaps 1) add iam module with new functions 2) adjust your classes 3) remove the existing functions?

@adriesse adriesse closed this Oct 19, 2019
@adriesse adriesse deleted the iam branch October 19, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants