Skip to content

fix reading MIDC files with mismatching header/data columns #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2019
Merged

fix reading MIDC files with mismatching header/data columns #822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b757f0
fix reading MIDC files with mismatching header/data columns
alorenzo175 Nov 18, 2019
1baf5f8
Update pvlib/iotools/midc.py
alorenzo175 Nov 18, 2019
7f7fccc
add timeout argument
alorenzo175 Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions docs/sphinx/source/whatsnew/v0.7.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ API Changes

* Changes related to spectral modifier (:issue:`782`):
* Changes to functions
- Added the argument `pw_min` and `pw_max`, default values 0.1 and 8 resp.,
- Added the argument `pw_min` and `pw_max`, default values 0.1 and 8 resp.,
to `atmosphere.first_solar_spectral_correction`. This function now returns NaN
if pw value higher than `pw_max`.

Expand All @@ -101,6 +101,9 @@ API Changes
argument for capability during the deprecation period.
* Parameter `pvsystem.DC_MODEL_PARAMS` is renamed to `pvsystem._DC_MODEL_PARAMS`.
Users should not rely on this dictionary's existence or structure.
* :py:func:`pvlib.iotools.midc.read_midc` now passes additional keyword
arguments to `pandas.read_csv`
* Add `timeout` argument to :py:func:`pvlib.iotools.midc.read_midc_raw_data_from_nrel`

Enhancements
~~~~~~~~~~~~
Expand Down Expand Up @@ -133,6 +136,8 @@ Bug fixes
longitude or latitude degree to an index number in a Linke turbidity lookup
table. Also rename the function to `clearsky._degrees_to_index`.
(:issue:`754`)
* Fix reading raw MIDC CSV files from NREL where the number of header
columns does not match the number of data columns.

Testing
~~~~~~~
Expand All @@ -152,7 +157,7 @@ Documentation
* Edited docstring for `pvsystem.sapm` to remove DataFrame option for input
`module`. The DataFrame option was never tested and would cause an error if
used. (:issue:`785`)
* Note warning about _TMY3.epw files retrieved from energyplus.net in docstring
* Note warning about _TMY3.epw files retrieved from energyplus.net in docstring
of `epw.read_epw`

Removal of prior version deprecations
Expand Down Expand Up @@ -180,3 +185,4 @@ Contributors
* Miguel Sánchez de León Peque (:ghuser:`Peque`)
* Tanguy Lunel (:ghuser:`tylunel`)
* Veronica Guo (:ghuser:`veronicaguo`)
* Tony Lorenzo (:ghuser:`alorenzo175`)
Loading