Skip to content

[ENH] KCD and Bregman conditional 2-sample tests #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Aug 30, 2023

Closes: #15
Follow-up to #19

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.
  • I have added a changelog entry succintly describing the change in this PR in the whats_new relevant version document.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
@adam2392 adam2392 requested a review from bloebp August 30, 2023 19:11
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #21 (03fb9d0) into main (256d8c9) will increase coverage by 6.88%.
The diff coverage is 98.49%.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   82.83%   89.71%   +6.88%     
==========================================
  Files           9       12       +3     
  Lines         402      535     +133     
  Branches       72       83      +11     
==========================================
+ Hits          333      480     +147     
+ Misses         49       35      -14     
  Partials       20       20              
Files Changed Coverage Δ
pywhy_stats/conditional_ksample/bregman.py 95.00% <95.00%> (ø)
pywhy_stats/conditional_ksample/base_propensity.py 100.00% <100.00%> (ø)
pywhy_stats/conditional_ksample/kcd.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bloebp bloebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only some minor comments and clarification questions.

Signed-off-by: Adam Li <[email protected]>
@adam2392 adam2392 requested a review from bloebp September 6, 2023 22:50
@bloebp bloebp merged commit 471c3e7 into py-why:main Sep 6, 2023
@adam2392 adam2392 deleted the kcdv2 branch September 11, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants