-
Notifications
You must be signed in to change notification settings - Fork 31
FIX: Update the "intro" section of the peer review guide #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The peer review guide is really coming along and I'm excited to see it get to this point. I see where you are going and I hope my review helps you get there a little easier. 🚀 🐍 ➕ 🧑🔬
technical scope listed below. | ||
|
||
If you are unsure whether your package is in scope for review, please | ||
open a [pre-submission inquiry using a GitHub Issue](https://github.com/pyOpenSci/software-review/issues/new?assignees=&labels=0%2Fpresubmission&template=presubmission-inquiry.md&title=) to get feedback from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The template is well laid out! Would there be a legitimate interest in knowing if the submitting author is committing to the package's maintenance at this point?
Edit: Ok, the 1-2 year(s) of commitment is mentioned elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. @Batalex do you think we should add that to the presubmission template as a link ? we just want to avoid people trying to publish a package (a one time activity) and be done vs vet it and maintain over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty of submitting a PR: pyOpenSci/software-submission#66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! i'll look at that PR today as well. going to focus on this pr first and then your pr in software review! thanks @Batalex i do think it's good to set expectations early. otherwise someone would get to the review and maybe walk away then. it saves us all time to tell them early what we expect :) excellent feedback
Co-authored-by: David Nicholson <[email protected]>
Co-authored-by: David Nicholson <[email protected]>
Co-authored-by: Ariane Sasso <[email protected]>
Co-authored-by: David Nicholson <[email protected]>
Co-authored-by: David Nicholson <[email protected]>
Co-authored-by: Ariane Sasso <[email protected]>
Co-authored-by: David Nicholson <[email protected]>
Co-authored-by: Ariane Sasso <[email protected]>
Co-authored-by: David Nicholson <[email protected]>
Co-authored-by: David Nicholson <[email protected]>
Co-authored-by: Ariane Sasso <[email protected]>
Co-authored-by: Ariane Sasso <[email protected]>
Co-authored-by: David Nicholson <[email protected]>
Co-authored-by: David Nicholson <[email protected]>
Co-authored-by: David Nicholson <[email protected]>
ok @Batalex @arianesasso @NickleDave i've addressed (i think) all of your comments. please feel free to have a look again. i'm going to add a zenodo file to this repo in another PR with your names in it. thank you for all of the great feedback I think it really improved this section of our peer review guidebook |
oh phew! what a great round of reviews. Thank you everyone! This is there because for now i'm merging this!! yahoo! |
@NickleDave yay!! i'm glad that you see where this is going! and so appreciative of all your feedback and help !! you're definitely helping me and pyOpenSci get to where we want to be!! |
…penSci#146) An overhaul of the peer review intro! yahoo
This PR updates and cleans up a lot of content in the About section of the peer review guide. It includes