Fix numpy dtypes test on big-endian architectures #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the test code on big-endian architectures: the array support (PR pybind#832) had hard-coded the little-endian '<' but we need to use '>' on big-endian architectures.
|
(Updated with a flake8 code style fix.) |
|
Looks good -- merged. |
|
(it's nice to have these CI tests for non-Intel architectures, although with a bit of latency..) We might want to push out another patch release so that distributions can update to the latest version. Are there any other patches that we are worth adding? |
|
I'll add a 2.2.3 milestone to track it, but I don't think it's worth rolling a new release just for this--it's only a patch to the test code rather than actually fixing anything in pybind itself. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the test code on big-endian architectures: the array support
(PR #832) had hard-coded the little-endian '<' but we need to use '>' on
big-endian architectures.
Fixes #1282