Enforces intel icpc >= 2017, fixes #1121 #1363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've assumed that the (Win pip) testing failures are not the PRs fault since the failure patterns show up for other PRs, too. Please let me know if I need to rebase or retrigger. |
Closed
|
This looks good, thank you! |
wjakob
pushed a commit
to wjakob/pybind11
that referenced
this pull request
Apr 29, 2018
wjakob
pushed a commit
that referenced
this pull request
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1700for__INTEL_COMPILER. Certainly as far back as 2017.0.2 does work and as far forward as 2016.0.3 doesn't work, so the 2017 boundary seems a good approximation.Thanks for everyone's help in trying to solve #1121 for 2016.