support for readonly buffers (#863) #1466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoslowski
force-pushed
the
readonly_buffers
branch
from
c902c16 to
b11705c
Compare
skoslowski
force-pushed
the
readonly_buffers
branch
from
b11705c to
25bae57
Compare
skoslowski
force-pushed
the
readonly_buffers
branch
from
25bae57 to
268b2ab
Compare
|
Related #1993 |
|
Merged now, apologies that this took a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a readonly flag to buffer_info objects. I consider this a first draft since it only covers the Buffer Protocol portion. Support for readonly in memoryview, array, ... will follow (as separate PRs)
I wanted to get some feedback on this part first:
readonlyadded as defaultfalseparameter to not break thingsreadonlyattribute is inserted at the end - consistent with the constructors, but deviating from the order inPy_Buffer.const T*constructor with 'readonly=true' - the same could be done for the others, but may require special casing types like nullptr_t