Catch exceptions thrown by repr() when called by the dispatcher #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e arguments" error. The dispatcher currently calls repr() if no overload matches, but repr() may throw causing the process to terminate with an uncaught exception. Handle that case more gracefully by falling back to a string that says that repr threw. With more work we could describe the error but that seems unnecessary, given the caller can just call repr() on the argument themselves if they want.
|
It looks like #2389 made a similar fix. Closing this PR. |
|
Whoops, sorry! No one noticed, when #2389 was getting reviewed :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dispatcher calls
repr()if no overload matches, butrepr()may throw causing the process to terminate with an uncaught exception. Handle that case more gracefully by catching the exception and instead using a string that simply says thatreprthrew.With more work we could describe the exception but that seems unnecessary given the caller can just call
repr()on the argument themselves if they want.Fixes jax-ml/jax#1257