-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Install headers using both headers and package_data #1995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit will break virtually every project that recursively includes pybind11 as a git submodule because you are changing the location of the header files. That's really a no-go for me. |
4193e3f
to
929fc3b
Compare
@wjakob, it turns out that changing the location is not needed. This is now backwards compatible. |
With this PR, pybind11 doesn't have to be installed before installing the downstream package and downstream packages need |
cc @sdebionne, @ax3l |
Thanks for the ping. I'll try this with spack as well after lunch. |
Hm, I do not think the new implementation helps much if we are in CMake-controlled/ |
Even in |
Okay, sounds good to me. |
@isuruf : I'll go ahead and merge this then, or did you plan to make additional changes? |
No. This is ready from my end. |
Ok -- merged! |
Many thanks to all contributes/reviewers to fix this long outstanding issue! 👍 |
pep517 is causing so much breakage, especially with the user isolation... |
But the |
@wjakob, any plans for a new release using this? |
+1 for the release. It would help a lot :-) |
FYI: I've finally release v2.5.0, which includes this fix. |
Fixes #1067
Fixes pybind/python_example#45