Skip to content

Fix inconsistent && qualification in argument_loader's call functions #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2020
Merged

Fix inconsistent && qualification in argument_loader's call functions #2057

merged 1 commit into from
Jan 5, 2020

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Jan 5, 2020

As discussed in #2044, all call methods should be consistently declared as && to indicate that *this will be invalidated by the calls due to moving the argcasters members.

@rhaschke rhaschke mentioned this pull request Jan 5, 2020
Closed
@wjakob wjakob merged commit 370a2ae into pybind:master Jan 5, 2020
@wjakob
Copy link
Member

wjakob commented Jan 5, 2020

Thanks!

@rhaschke rhaschke deleted the fix-inconsistent-semantics branch January 30, 2020 12:38
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhaschke @wjakob