Skip to content

Update binding example for virtual function doc. #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update binding example for virtual function doc. #2083

wants to merge 2 commits into from

Conversation

AntoinePrv
Copy link
Contributor

Hello,

Just suggesting a small change in the documentation.
In section "Combining virtual functions and inheritance", the bindings with trampoline class don't mention the inheritance to parent class.
It may be straightforward for some people, but, as a beginner, it threw me off for a bit.
I suggest showing the bindings as they would look in a complete example.

@wjakob
Copy link
Member

wjakob commented Jun 30, 2020

Merged, thanks! (I committed to master directly, since there were some merge issues with this PR in the meantime)

@wjakob wjakob closed this Jun 30, 2020
wjakob added a commit that referenced this pull request Jun 30, 2020
@AntoinePrv AntoinePrv deleted the patch-1 branch July 1, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants