Skip to content

ci: include Python 3.9 RC1 #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2020
Merged

ci: include Python 3.9 RC1 #2387

merged 1 commit into from
Aug 12, 2020

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Aug 12, 2020

The patch we submitted to Python should be included in yesterday's Python 3.9 RC1, so this should pass now. Fingers crossed!

@henryiii
Copy link
Collaborator Author

No "real" changes, just adding Python 3.9rc1 on macOS (though 3.9 was building and testing NumPy before - we haven't traditionally done that (and it's slow), so I think that's fine to drop, it was really just an oversight before).

Copy link
Collaborator

@bstaletic bstaletic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, this looks fine. I'm just wondering if we should care before 3.9 gets a stable release.

@henryiii
Copy link
Collaborator Author

It already helped us get a PR into Python 3.9 before the release :) python/cpython#21600

@henryiii
Copy link
Collaborator Author

The sooner we catch bugs, either in our code or in Python (as linked above), the better for everyone. The goal is to be Python 3.9 ready on the day of release.

@henryiii henryiii merged commit 1534e17 into pybind:master Aug 12, 2020
@henryiii henryiii deleted the ci/pydev branch August 12, 2020 18:09
henryiii added a commit to henryiii/pybind11 that referenced this pull request Aug 12, 2020
henryiii added a commit that referenced this pull request Aug 18, 2020
* fix: throwing repr caused a segfault

* fixup! ci: include Python 3.9 RC1 (#2387)
@henryiii henryiii added the ci related to the CI system label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci related to the CI system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants