docs: move CONTRIBUTING #2402
Merged
docs: move CONTRIBUTING #2402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
approved these changes
Aug 17, 2020
Happy with that, but I feel this is something that should pass @wjakob's eye, since it's changing one of the promises of pybind11. |
|
Agreed. I don't like promising anything we don't test, so if we promise earlier, we should add a test. |
henryiii
force-pushed
the
docs/contrib2
branch
from
8912263 to
3f87a41
Compare
|
I've made the statement less promisy and more truthful (tested on 7.3) so this can move forward. @wjakob has already signed off on the CONTRIBUTING move, which was the focus of this PR. |
|
I'd still like an answer to the minimal PyPy version we're supporting. We could potentially get rid of a bunch of code, if we pick a sane, modern, by-PyPy-supported version. But that shouldn't stop this PR, indeed. Maybe create an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #2377, moves contributing.
Also modernizes some of README, including adding a prominent link to the contributing document.
The most notable point is the update to the PyPy version - currently we test PyPy/PyPy3 7.3. If we state an earlier version here, we should probably test it. Open to doing something different though.