Skip to content

fix: install to DATAROOTDIR instead of hardcoding share #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2020
Merged

fix: install to DATAROOTDIR instead of hardcoding share #2584

merged 1 commit into from
Oct 13, 2020

Conversation

henryiii
Copy link
Collaborator

Closes #2571; this is defined to share, and unlike DATADIR, is not sometimes overwritten incorrectly for storing CMake files.

@henryiii
fix: install to DATAROOTDIR instead of hardcoding share
fad2380 
Closes pybind#2571; this is defined to share, and unlike DATADIR, is not sometimes overwritten incorrectly for storing CMake files.
@henryiii henryiii added this to the v2.6.0 milestone Oct 13, 2020
@henryiii
Copy link
Collaborator Author

I don't see any reason this can't go into 2.6.0, as it's just defined to share. This is useful for cross-compiling, as it can be set manually by toolchains. It also should correctly support installing to / if someone wanted to do that, as all GNU paths get usr added.

@henryiii henryiii merged commit edda89b into pybind:master Oct 13, 2020
@henryiii henryiii deleted the fix/cmake_configdir branch October 13, 2020 17:08
@chronitis chronitis mentioned this pull request Oct 30, 2020
Merged
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.

[QUESTION] Why is GNUInstallDirs not used in CMakeLists.txt?
1 participant
@henryiii