Enable and apply clang-tidy readability and misc fixes. #3052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
commented
Jun 20, 2021
| @@ -75,8 +77,10 @@ struct C { | |||
| # pragma GCC diagnostic push | |||
| # pragma GCC diagnostic ignored "-Wdeprecated" | |||
| #endif | |||
| int m7(int x) throw() { return x-7; } | |||
| int m8(int x) const throw() { return x-8; } | |||
| // NOLINTNEXTLINE(modernize-use-noexcept) | |||
There was a problem hiding this comment.
This check discourages the user of throw, but since these are explicilty deprecated tests, I add nolints to prevent them from being changed.
henryiii
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
This all looks very good to me! Thanks! Love seeing that someone is finally filling out the clang-tidy checks, see my comment at #2478 (comment) :)
|
I'm calling this a fix due to the fact that adding const technically is better, as you can only call const methods on a const object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is one readability improvement with const return types I would like to enable but it causes error sadly that need to be fixed.
Suggested changelog entry: