Skip to content

Scratch PR: clone of #4293 that could be merged immediately without disrupting anything #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Nov 3, 2022

Description

Scratch PR for testing.

Rebased on current master.

Suggested changelog entry:

@rwgk rwgk added the python dev Working on development versions of Python label Nov 3, 2022
@rwgk
Copy link
Collaborator Author

rwgk commented Nov 3, 2022

Note: Please ignore the CI results that are currently showing: that was a failed attempt to make "Upstream" test with Python 3.12. Unfortunately 3.12.0a1 isn't available yet at https://github.com/raw/actions/python-versions/main/versions-manifest.json

When I saw the Upstream failure I canceled the CI workflow, to not waste CPU cycles.

The previous CI run, without Upstream, was successful.

rwgk added a commit to rwgk/pybind11 that referenced this pull request Nov 17, 2022
Modifications are:

* Backward compatibility (no ABI break), as originally under PR pybind#4307.
* Naming: `get_python_state_dict()`, `has_pybind11_internals_capsule()`
* Report error retrieving `internals**` from capsule instead of clearing it.

Locally tested with ASAN, MSAN, TSAN, UBSAN (Google-internal toolchain).
@rwgk
Copy link
Collaborator Author

rwgk commented Nov 19, 2022

Closing this PR because:

@rwgk rwgk closed this Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python dev Working on development versions of Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants