Alternative approach to #3807 #4612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use case: `Base` not specified in `classh<Derived>` statement, but passing Derived as Base works anyway.
….py (quick experiment)
…_capsule.py (quick experiment)" This reverts commit e8f0749.
…sule_get_pointer __getattr__ issues.
…ntation and new helper functions.
|
@wangxf123456 FYI This PR all by itself (without additional changes in PyCLIF-pybind11) fixes //third_party/clif/testing/python:final_test For completeness, the error (before this PR is applied) was: |
|
Google-internal global testing ID: OCL:522836781:BASE:523134970:1681144155208:16ce654b |
wangxf123456
approved these changes
Apr 10, 2023
3 tasks
wangxf123456
pushed a commit
to google/clif
that referenced
this pull request
Apr 12, 2023
This change was enabled by pybind/pybind11#4612 TGP-tested via TGP-head 2023-04-06 (cl/522266833) re-run with this change: * https://fusion2.corp.google.com/presubmit/tap/522266833/OCL:522266833:BASE:522968984:1681064677276:5304c616;groups=Passing/targets * 116 Passing Example generated code: ``` UnspecDerived_class.def( "as_clif_testing_unspecified_inheritance_UnspecBase", [](::clif_testing::unspecified_inheritance::UnspecDerived* self) { return py::capsule(static_cast<void *>(self)); } ); ``` PiperOrigin-RevId: 523233130
wangxf123456
pushed a commit
to google/clif
that referenced
this pull request
Apr 14, 2023
This change was enabled by pybind/pybind11#4612 TGP-tested via TGP-head 2023-04-06 (cl/522266833) re-run with this change: * https://fusion2.corp.google.com/presubmit/tap/522266833/OCL:522266833:BASE:522968984:1681064677276:5304c616;groups=Passing/targets * 116 Passing Example generated code: ``` UnspecDerived_class.def( "as_clif_testing_unspecified_inheritance_UnspecBase", [](::clif_testing::unspecified_inheritance::UnspecDerived* self) { return py::capsule(static_cast<void *>(self)); } ); ``` PiperOrigin-RevId: 523233130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach supports an important PyCLIF use case:
Basenot specified inclassh<Derived>statement, but passingDerivedasBaseworks anyway.Description
Suggested changelog entry: