Move eigen dl version to single file, update to 3.3.2 #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the eigen download version and extraction path to a single file (.eigen-build-version), loaded by both the appveyor and travis-ci scripts. It also updates the eigen version from 3.3.0 to the latest 3.3.2. Finally it saves a tiny amount of disk space on the travis-ci builds by extracting the .tar.gz on the fly rather than downloading first then decompressing the saved file.
Merged
|
Hm, I'm not a big fan of all of these dot files in the root directory. Is there any reason why we can't leave the version as is? The particular Eigen release being used does not matter that much in any case since we rely on stable API. |
|
I was thinking it might make sense to move this and some of the scripts currently embedded in the .travis file into tools. |
|
You're right, though, that the eigen version doesn't particularly matter (in any case, we're already testing with the latest one in the debian builds). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the eigen download version and extraction path to a single file (.eigen-build-version), loaded by both the appveyor and travis-ci scripts.
It also updates the eigen version from 3.3.0 to the latest 3.3.2.
Finally it saves (a tiny amount of) storage use on the travis-ci builds by extracting the .tar.bz2 on the fly rather than downloading first then decompressing the saved file. (It also saves slightly on download bandwidth by downloading the source tar.bz2 instead of the tar.gz).