Make bad kwarg arguments try next overload #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pybind#688. My (commented) assumption that such an error is "highly likely to be a caller mistake" was proven false by pybind#688.
With the previous commit, output can be very confusing because you only see positional arguments in the "invoked with" line, but you can have a failure from kwargs as well (in particular, when a value is invalidly specified via both via positional and kwargs). This commits adds kwargs to the output, and updates the associated tests to match.
jagerman
force-pushed
the
kwargs-error-fix
branch
from
5688b5d to
ddcf9fd
Compare
|
Merged, thank you! |
|
Arg, that workaround still triggers a style failure: it needs spaces around the + |
|
You could also just revert the fix entirely and instead just don't apply that check for .py files (it really is mainly aimed at C++ style anyway). |
|
I amended that commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #688.
My (commented) assumption that such an error is "highly likely to be a caller mistake" was proven false by #688.