Bigendian test fixes #699
Merged
Bigendian test fixes #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some numpy tests failures on ppc64 in big-endian mode due to little-endian assumptions. Fixes pybind#694.
Fixes test failure on Fedora 25.
jagerman
force-pushed
the
bigendian-test-fixes
branch
from
ca0287c to
3745430
Compare
|
Great catch, and that you for going through the effort of testing in QEMU :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #694.
Test suite fixes for big-endian architectures (i.e. Fedora ppc64 in #694).
Also includes a fix for 'ExceptionInfo.match' not being present in pytest before v3.0 (e.g. Fedora 25's pytest package).