re-add branch we dropped in the past #11030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
May 27, 2024
src/rust/src/backend/utils.rs
Outdated
| let pem_bytes = if password.is_empty() { | ||
| rsa.private_key_to_pem()? | ||
| } else { | ||
| if cryptography_openssl::fips::is_enabled() { |
There was a problem hiding this comment.
This same issue is applicable to DSA and EC right? I think this should be higher up, at line 148 or so.
alex
approved these changes
May 27, 2024
alex
requested changes
May 27, 2024
Co-authored-by: Alex Gaynor <[email protected]>
alex
previously approved these changes
May 27, 2024
alex
reviewed
May 27, 2024
tests/hazmat/primitives/test_dsa.py
Outdated
Comment on lines
729
to
746
| @pytest.mark.supported( | ||
| only_if=lambda backend: backend._fips_enabled, | ||
| skip_message="Requires FIPS", | ||
| ) | ||
| def test_traditional_serialization_fips(self, backend): | ||
| key_bytes = load_vectors_from_file( | ||
| os.path.join("asymmetric", "PKCS8", "unenc-dsa-pkcs8.pem"), | ||
| lambda pemfile: pemfile.read().encode(), | ||
| ) | ||
| key = serialization.load_pem_private_key(key_bytes, None, backend) | ||
| assert isinstance(key, dsa.DSAPrivateKey) | ||
| with pytest.raises(ValueError): | ||
| key.private_bytes( | ||
| serialization.Encoding.PEM, | ||
| serialization.PrivateFormat.TraditionalOpenSSL, | ||
| serialization.BestAvailableEncryption(b"password"), | ||
| ) | ||
|
|
There was a problem hiding this comment.
This is never reachable, we don't support DSA with FIPS
alex
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let's see if this fails since we shouldn't have a test covering this branch...