Skip to content

smime signer support #5465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 19, 2020
Merged

smime signer support #5465

merged 9 commits into from
Sep 19, 2020

Conversation

reaperhulk
Copy link
Member

refs #5433

@reaperhulk reaperhulk mentioned this pull request Sep 15, 2020
Closed
alex
alex reviewed Sep 15, 2020
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use _der.py to parse any of these things instead of rando string nonsense?

@reaperhulk
Copy link
Member Author

_der.py can probably be used, yes, but it will be a bit of work to figure out exactly how to drill to the right nested sections of this structure.

decaz
decaz reviewed Sep 15, 2020
View reviewed changes
WhyNotHugo
WhyNotHugo reviewed Sep 16, 2020
View reviewed changes
@WhyNotHugo
Copy link
Contributor

This branch work for me as a fix to #5433. Thanks! 👍

alex
alex reviewed Sep 17, 2020
View reviewed changes
alex
alex reviewed Sep 18, 2020
View reviewed changes
alex
alex reviewed Sep 18, 2020
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one

alex
alex approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM. can't merge until zuul stops failing

@reaperhulk
Copy link
Member Author

@alex CI is passing now 😄

@alex alex merged commit 20c0388 into pyca:master Sep 19, 2020
@reaperhulk reaperhulk deleted the smime-time branch September 20, 2020 19:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@decaz decaz decaz left review comments

@WhyNotHugo WhyNotHugo WhyNotHugo left review comments

@alex alex alex approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reaperhulk @WhyNotHugo @alex @decaz