Migrate ChaCha20Poly1305 AEAD to Rust #9399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
chacha20poly1305-rust
branch
from
4137295 to
cbcdb88
Compare
alex
force-pushed
the
chacha20poly1305-rust
branch
2 times, most recently
from
b5beafc to
9e9ddb1
Compare
|
Grumble, not working due to openssl/openssl#21853 |
alex
force-pushed
the
chacha20poly1305-rust
branch
2 times, most recently
from
e13d325 to
d494ddf
Compare
alex
force-pushed
the
chacha20poly1305-rust
branch
5 times, most recently
from
88e7325 to
85b8852
Compare
alex
force-pushed
the
chacha20poly1305-rust
branch
2 times, most recently
from
035e0ab to
34a6b82
Compare
alex
force-pushed
the
chacha20poly1305-rust
branch
from
34a6b82 to
cdf2d7a
Compare
alex
force-pushed
the
chacha20poly1305-rust
branch
from
cdf2d7a to
1df836a
Compare
alex
force-pushed
the
chacha20poly1305-rust
branch
2 times, most recently
from
33cb870 to
76553bc
Compare
|
This disable ctx reuse on OpenSSL 3.0-3.2. There's a bunch of code we can delete once we support only versions with workign copies. Even with the ctx reuse disabled on 3.0.2, which is used in the benchmarks, it's 20% faster than main. |
alex
force-pushed
the
chacha20poly1305-rust
branch
from
76553bc to
272dd6b
Compare
alex
force-pushed
the
chacha20poly1305-rust
branch
from
272dd6b to
73614ab
Compare
|
Do we use fixedpool anywhere now that this PR removes it from chacha? |
|
Nope. Will remove it. |
reaperhulk
approved these changes
Jan 13, 2024
|
I do not envy future us looking at those conditionals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.