Switch to setuptools-scm, include tests in source tarball. #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! With this changes, the generated sdist works for us. Could you make similar changes to zlib-ng too? I didn't want to file a separate issue before getting feedback on the first project. |
|
Sure, I will add this to python-zlib-ng as well. I cannot promise to make a release asap, but I will take a look at the bug that was discovered eventually, and then that will be the moment I release the new version. |
|
Thanks! No hurry with the release, we've patched the issue for now. Having it solved in the next release is a major gain too. |
|
Done. Now also fixed in python-zlib-ng. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes #231
@mgorny, does this fix your problems?
I managed to find the issue with setuptools-scm. Exclude-package-data works, but somehow something is cached in the
builddir. Unless you delete it, there is no effect of your actions in pyproject.toml. Which leads to a lot of frustrations in the "why doesn't this setting work" category. I only found this on the THIRD attempt at using setuptools-scm.Python packaging: slightly better than C packaging!