Don't strip newlines when ANSI text is sent to print() #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnsiDecoder.decode() takes a single str and returns a list of Text split by newline. If this is used directly, newlines in the source will not be restored when sent to print(). Using Lines instead of list lets us indicate to Rich that these Text objects should be interspersed with newlines. Ref https://github.com/Textualize/rich/blob/master/rich/ansi.py#L126
|
Label error. Requires exactly 1 of: bug, chore, enhancement, major, minor, patch, skip-changelog. Found: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnsiDecoder.decode()takes a singlestrand returns a sequence ofTextsplit by newline. If this is used directly, newlines in the source will not be restored when sent to print().Using
Linesinstead oflistlets us indicate to Rich that theseTextobjects should be interspersed with newlines.Ref https://github.com/Textualize/rich/blob/master/rich/ansi.py#L126