Skip to content

use vm_name as first positional argument in up() #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2022
Merged

use vm_name as first positional argument in up() #111

merged 2 commits into from
Mar 30, 2022

Conversation

konstruktoid
Copy link
Collaborator

@konstruktoid konstruktoid commented Mar 30, 2022 •
edited by ssbarnea
Loading

Sets vm_name as first positional argument in up()

Closes: #65

@konstruktoid
use vm_name as first positional argument
4748058 
Signed-off-by: Thomas Sjögren <[email protected]>
@konstruktoid
remove dummy boxes
1d109af 
Signed-off-by: Thomas Sjögren <[email protected]>
@ssbarnea ssbarnea added the major label Mar 30, 2022
@konstruktoid konstruktoid merged commit cf2750c into pycontribs:main Mar 30, 2022
@konstruktoid konstruktoid deleted the issue65 branch March 30, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@apatard apatard apatard approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The signature for 'up' is inconsistent with other VM methods
3 participants
@konstruktoid @ssbarnea @apatard