Skip to content

Conversation

alexmojaki
Copy link
Contributor

Closes #1044

@alexmojaki alexmojaki requested a review from Copilot April 29, 2025 13:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the sample query in the documentation to use the WITHIN GROUP syntax for computing percentiles, aligning it with the latest recommended query patterns.

  • Replaces the original extraction of duration in milliseconds with a multiplication of the duration by 1000.
  • Updates percentile function calls to the new WITHIN GROUP pattern.

Copy link

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ea17fdc
Status: ✅  Deploy successful!
Preview URL: https://48ffa7ee.logfire-docs.pages.dev
Branch Preview URL: https://alex-within-group.logfire-docs.pages.dev

View logs

Copy link
Contributor

hyperlint-ai bot commented Apr 29, 2025

PR Change Summary

Updated the percentiles query to utilize the WITHIN GROUP clause for improved accuracy in calculating percentiles.

  • Modified the SQL query to use WITHIN GROUP for percentile calculations.
  • Changed the way duration is calculated in the query.

Modified Files

  • docs/integrations/web-frameworks/index.md

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@alexmojaki alexmojaki enabled auto-merge (squash) April 29, 2025 13:13
@alexmojaki alexmojaki merged commit a616cab into main Apr 29, 2025
16 checks passed
@alexmojaki alexmojaki deleted the alex/within-group branch April 29, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WITHIN GROUP query syntax

1 participant