Skip to content

Odd test variations based on download source #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sambler opened this issue Jul 14, 2020 · 8 comments · Fixed by #809
Closed

Odd test variations based on download source #806

sambler opened this issue Jul 14, 2020 · 8 comments · Fixed by #809

Comments

@sambler
Copy link

sambler commented Jul 14, 2020

When 0.9.0 was released I saw some extra test failures compared to rc1. I have since found that the test results from github tag of 0.9.0 are different than the 0.9.0 release available from pypi.

Comparing the tarball from github and pypi, I see setup.cfg varies in formatting (spaces/tabs), while _version.py has >500 lines different. As the shorter _version.py should be output from the repo script, I don't expect either should cause variations in tests.

This is running on FreeBSD 12.1 amd64

0.9.0-github
1 failed, 113 passed, 56 skipped, 3 xfailed, 1 xpassed

0.9.0-pypi
1 failed, 109 passed, 56 skipped, 3 xfailed, 1 xpassed, 1 warnings, 4 error

@bashtage
Copy link
Contributor

Which tests specifically fail?

@sambler
Copy link
Author

sambler commented Jul 15, 2020

the two links are log files of the test output.

@bashtage
Copy link
Contributor

Seems to be something to do with the pandas and/or pytest you are using. There is no version information available for installed packages in the log.

@sambler
Copy link
Author

sambler commented Jul 15, 2020

pandas-0.24.2 - pytest 4.5.0 so both ports need updating.

But besides the updates, how can the 0.9.0 tarball from github and 0.9.0 from pypi give different results when they are using the same modules?

Between the two tests the pandas-datareader source tarball is the only changing factor.
Do you get the same results from both tarballs? or is it just me?

@bashtage
Copy link
Contributor

What is the syntax fo the pytest command is used to involke the test?

@sambler
Copy link
Author

sambler commented Jul 15, 2020

The cmd used with the logs is cd $WRKSRC && python3.7 -m pytest pandas_datareader/tests

@bashtage
Copy link
Contributor

And what is $WRKSRC?

bashtage added a commit to bashtage/pandas-datareader that referenced this issue Jul 15, 2020
Add tester to fully test install
Fix issues related to testing installed package
Update isort

closes pydata#806
bashtage added a commit to bashtage/pandas-datareader that referenced this issue Jul 15, 2020
Add tester to fully test install
Fix issues related to testing installed package
Update isort

closes pydata#806
@bashtage bashtage mentioned this issue Jul 15, 2020
5 tasks
bashtage added a commit to bashtage/pandas-datareader that referenced this issue Jul 15, 2020
Add tester to fully test install
Fix issues related to testing installed package
Update isort

closes pydata#806
@bashtage
Copy link
Contributor

I have found the issue; it won't be fixed until 0.9.1.

bashtage added a commit to bashtage/pandas-datareader that referenced this issue Jul 25, 2020
Add tester to fully test install
Fix issues related to testing installed package
Update isort

closes pydata#806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants